On Fri, 22 Jan 2021 10:08:51 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
> This particular issue JDK-8256283, is a specific case of IOOBE when, rootItem > is not shown, some children including first child are selected, then all > children are removed and sort() is invoked. The sort() fails with an IOOBE. > This PR only addresses this specific IOOBE. > Root cause of this issue is that the selection is not cleared after rootItems > children are removed. In addition to this, there are few other scenarios when > selection is not updated correctly, which are collected under an umbrella > task [JDK-8248217](https://bugs.openjdk.java.net/browse/JDK-8248217). Fix for > [JDK-8248217](https://bugs.openjdk.java.net/browse/JDK-8248217) would require > good amount refactoring of selection model. > > The fix for this issue is to avoid sort() when > rootItem.getChildren().isEmpty(). > Added a unit test with the fix, which fails without fix and passes with fix. This pull request has now been integrated. Changeset: db6941de Author: Ambarish Rapte <ara...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/db6941de Stats: 27 lines in 2 files changed: 26 ins; 0 del; 1 mod 8256283: IndexOutOfBoundsException when sorting a TreeTableView Reviewed-by: kcr ------------- PR: https://git.openjdk.java.net/jfx/pull/384
