On Mon, 1 Feb 2021 16:52:10 GMT, Arun Joseph <ajos...@openjdk.org> wrote:
>> Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2
>> onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms
>> `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a
>> few ms early. The same is not present in `WorkQueueGeneric` and needs to be
>> added.
>>
>> Also removing `WorkQueueWin` as it's removed for WebKit as well.
>
> Arun Joseph has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update comment
modules/javafx.web/src/main/native/Source/WTF/wtf/generic/WorkQueueGeneric.cpp
line 85:
> 83: // so far.
> 84: const Seconds slopAdjustment { 20_ms };
> 85: if (delay)
Since `delay` is an object of type `Seconds`, should this be `if
(delay.milliseconds())`? Otherwise, won't it just check whether the object is
non-null?
-------------
PR: https://git.openjdk.java.net/jfx/pull/391
