On Wed, 10 Feb 2021 08:52:55 GMT, Abhinay Agarwal 
<[email protected]> wrote:

> Both DialogPane and ContextMenu have a child node with a style-class 
> `graphic-container`. This leads to a corner case where an unwanted style is 
> applied to ContextMenu when it is shown on a DialogPane.

Both the fix and the new tests look good to me. I can confirm that it fixes the 
test program attached to JBS, and that the new ContextMenu unit test fails 
before and passes after the fix.

This looks like a simple and safe fix, but I'd like a second reviewer for 
anything that touches the `modena.css` stylesheet.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/400

Reply via email to