On Wed, 27 Jan 2021 16:39:55 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> 
wrote:

>> This does look like a much more manageable approach.
>> 
>> One thing to be aware of from a bookkeeping point of view is that a JBS 
>> issues is resolved by a single PR. Once a PR has been integrated for a given 
>> JBS bug ID, that bug ID cannot be reused.
>> 
>> This means that each separate PR will need it's own JBS issue to be filed, 
>> even if those enhancements taken together are part of a larger set of 
>> improvements. Incremental improvements are fine (and in this case a good way 
>> to proceed), but you might give some thought to the title of each such 
>> improvement. I wouldn't want to see 5 fixes go in each with the same title 
>> of `Simplify and update glass gtk backend`.
>
> It's been pointed out about this
> https://stackoverflow.com/questions/49512491/javafx-getting-single-resize-events
> 
> My tests point out that this PR causes less sizing events that the current 
> master branch, but I also think this could be improved further.
> 
> But, by the nature of X and window managers, window sizes does not account 
> decoration frames, but javafx does (probably mimicking windows behavior). 
> Given this information I probably could reduce further the sizing events, but 
> not make it equivalent to windows.

Changed to WIP to reduce sizing events.

-------------

PR: https://git.openjdk.java.net/jfx/pull/367

Reply via email to