> Issue is that the size of properties that are relatively(`em`) sized is not > computed correctly when the reference `-fx-font-size` is also specified > relatively and is nested. > > Fix is a slight variation of an earlier suggestion in [the > PR](https://github.com/javafxports/openjdk-jfx/pull/94). > > Fix is very specific to this scenario and did not show any side effect nor > any test failure. > > There are 12 new unit tests added along with fix: > - Two tests fail before and pass after this fix. These test verify the > reported failing scenario. > sameRelativeFontSizeNestedParentTest > relativeFontSizeDeepNestedParentControlTest > - Two other tests fail both before and after this fix. They are not related > to the fix. These two tests are ignored. I shall file new JBS issues to track > these cases and update PR with the IDs added to @Ignore. > propertySizesRelativeToFontSizeOfControlTest > propertySizesRelativeToFontSizeOfParentTest > - Other 8 tests are sanity tests which pass both before and after this fix.
Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: update to recalculate properties when font size changes ------------- Changes: - all: https://git.openjdk.java.net/jfx/pull/397/files - new: https://git.openjdk.java.net/jfx/pull/397/files/e2372f4d..816304de Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=397&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=397&range=00-01 Stats: 653 lines in 5 files changed: 443 ins; 71 del; 139 mod Patch: https://git.openjdk.java.net/jfx/pull/397.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/397/head:pull/397 PR: https://git.openjdk.java.net/jfx/pull/397
