On Mon, 8 Mar 2021 07:49:23 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Issue is that the size of properties that are relatively(`em`) sized is not >> computed correctly when the reference `-fx-font-size` is also specified >> relatively and is nested. >> >> Fix is a slight variation of an earlier suggestion in [the >> PR](https://github.com/javafxports/openjdk-jfx/pull/94). >> >> Fix is very specific to this scenario and did not show any side effect nor >> any test failure. >> >> There are 12 new unit tests added along with fix: >> - Two tests fail before and pass after this fix. These test verify the >> reported failing scenario. >> sameRelativeFontSizeNestedParentTest >> relativeFontSizeDeepNestedParentControlTest >> - Two other tests fail both before and after this fix. They are not related >> to the fix. These two tests are ignored. I shall file new JBS issues to >> track these cases and update PR with the IDs added to @Ignore. >> propertySizesRelativeToFontSizeOfControlTest >> propertySizesRelativeToFontSizeOfParentTest >> - Other 8 tests are sanity tests which pass both before and after this fix. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > minor corrections in comments Marked as reviewed by dgrieve (Reviewer). ------------- PR: https://git.openjdk.java.net/jfx/pull/397
