On Wed, 10 Mar 2021 22:32:26 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> Regarding the CSR, it is only concerned with the public API, including the >> specification (javadoc-generated API documentation), and any behavioral >> changes. >> >> You can leave the CSR in the Draft state until there is something to >> document in the Specification section, and the review of the PR is far >> enough along so that those changes are likely to be final. For this PR, the >> changes that need to be documented in the CSR haven't been made yet. The >> changes needed will be in the javadoc comments of public >> `Application::launch` methods. > > I've now added the new Exception to the JavaDoc of the Application. The API spec changes look good. You can add that to the Specification section of the CSR. You can either paste the diffs for the javadoc comments, or else just add the one new line for each method. Either way, the name of the class (javafx.application.Application) should be listed prior to the diffs / additions. Also, make it clear which methods are getting the new `@exception` tags. ------------- PR: https://git.openjdk.java.net/jfx/pull/421
