On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last time Microsoft changed the environment, our Windows builds started > failing (because we hard-coded it). I temporarily bumped it to the > then-current version as a fix for > [JDK-8256686](https://bugs.openjdk.java.net/browse/JDK-8256686), and filed > this bug -- [JDK-8255713](https://bugs.openjdk.java.net/browse/JDK-8255713) > -- as a followup. It's failing again because of another update to the GitHub > actions environment, so it's time to fix it to discover the latest version > rather than hardcode it. > > NOTE to reviewers: This will need to be tested with local and CI builds as > well as GitHub actions, since there are changes in the `win.gradle` script > (and associated `genVSproperties.bat` script). lgtm, local build on my machine completes successfully and GitHub actions build also completed on this PR. ------------- Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/427
