On Tue, 23 Mar 2021 18:24:40 GMT, John Neffenger <jgn...@openjdk.org> wrote:
> As the comment in the test case mentions, "Tests require that default locale > is en_US." The default locale is required by the objects created in the > static method `implementations`, marked with the JUnit annotation > `@Parameterized.Parameters`. So the static method `initDefaultLocale`, marked > with the JUnit annotation `@BeforeClass`, calls the method to set the > required default: `Locale.setDefault(Locale.US)`. > > The problem occurs because the `@Parameterized.Parameters` method is called > before the `@BeforeClass` method, so the system locale is used as the default > instead of `Locale.US`. > > The fix is to move the call to the first instruction of the > `@Parameterized.Parameters` method so that the default is set before it's > required. Ah, I hadn't realized that. So this is a correction to the earlier fix for [JDK-8160039](https://bugs.openjdk.java.net/browse/JDK-8160039). Looks good. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/438
