On Tue, 23 Mar 2021 09:57:11 GMT, Ambarish Rapte <[email protected]> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263402
>> Rewrote the style memoryleak test
>
> Provided few comments on test.
I've added the requested changes from the codereview
> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line 48:
>
>> 46: import static org.junit.Assert.fail;
>> 47: import static org.junit.Assert.assertTrue;
>> 48:
>
> The packages Application, Node and Parent are not used.
done
> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line
> 100:
>
>> 98: Platform.runLater(() -> {
>> 99: Platform.exit();
>> 100: });
>
> `Platform.exit()` can be called from any thread. So `Platform.runLater` is
> not required.
done
> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line
> 102:
>
>> 100: });
>> 101: }
>> 102: }
>
> Include a new line at end of file.
done
-------------
PR: https://git.openjdk.java.net/jfx/pull/424
