On Wed, 31 Mar 2021 10:58:27 GMT, Jose Pereda <jper...@openjdk.org> wrote:
> This PR replaces the deprecated iOS native view for web (UIWebView) with > WKWebView. > > While most of the native API can be easily replaced from one to the other, > there are some changes that affect the scripts execution, and therefore some > minor changes in WebEngine/JS2JavaBridge are required. > > There is also a side effect if named members of JS objects are used via > JSObject::setMember. The Java callbacks to JavaScript are now async, and the > return value will be ignored. A workaround is to use JSObject::call instead > to pass that value. This should be dealt with in a follow-up issue. > > Also, a peer is provided to allow having a JavaFX node that can be resized > and relocated. > > This PR has been tested on iOS, loading URLs and local html files with JS > scripts. I'll defer to @johanvos for the review. I noted one minor formatting issue that you might want to fix. modules/javafx.web/src/ios/java/com/sun/javafx/sg/prism/web/NGWebView.java line 80: > 78: return true; > 79: } > 80: } Minor: missing newline at end of file. ------------- PR: https://git.openjdk.java.net/jfx/pull/449
