On Wed, 31 Mar 2021 21:24:18 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> The fix looks good to me. I haven't run the test yet, but it seems OK except >> for the handling of GC to check for the leak (I left an inline comment). > > Oh, I thought that `javafx.graphics` already referenced it. The following > should be sufficient: > > --- a/build.gradle > +++ b/build.gradle > @@ -2089,6 +2089,7 @@ project(":graphics") { > stubCompile group: "junit", name: "junit", version: "4.8.2" > > antlr group: "org.antlr", name: "antlr4", version: "4.7.2", > classifier: "complete" > + testCompile project(":base").sourceSets.test.output > compile project(':base') > } Did you find that it worked without the addition of the dependency to `build.gradle`? You didn't commit that change. I guess we'll see what the GitHub actions build shows. ------------- PR: https://git.openjdk.java.net/jfx/pull/448