On Thu, 1 Apr 2021 12:19:40 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Alexander tried it on our CI build machine yesterday and it builds fine >> there, too. I should add that I was building on a very old Ubuntu 16.04 >> system. >> >>> Since this PR introduces memset in the audio-buffer.c file, I think it is >>> safest to include string.h in this file as well, as this removes the >>> dependency on that file to be included indirectly. >> >> I was thinking the same thing. There is one more file that should include >> `<string.h>`: `qtdemux_tags.c` uses `strlen`and fails to compile on my >> system. With the change to include `string.h` in those two files, the build >> now passes on my system. > > All my testing looks good on all three platforms. I'll take a look at the > diffs next. > > One thing I did spot is that you need to update `gstreamer.md` and `glib.md` > to bump the version numbers. It now builds for me on my old Linux box. And the changes to the /legal/ files looks good. One more thing I just thought of: we should do a test build on macOS aarch64. I have no reason to believe that there will be a problem, but worth double-checking. ------------- PR: https://git.openjdk.java.net/jfx/pull/447
