On Fri, 9 Apr 2021 06:55:55 GMT, Matthias Bläsing 
<github.com+2179736+matthiasblaes...@openjdk.org> wrote:

>> tests/system/src/testapp7/java/mymod/myapp7/LocalStorageAccessWithModuleLayer.java
>>  line 92:
>> 
>>> 90:                     }
>>> 91:                 });
>>> 92:         
>>> webview.getEngine().load(LocalStorageAccessWithModuleLayer.class.getResource("/LocalStorageAccess.html").toExternalForm());
>> 
>> This fails to find the resource when I run the test via gradle. I recommend 
>> putting it in the same package as the class and removing the leading `/` 
>> (e.g., see the FXML resources in `testapp6` or `testscriptapp1`).
>
> Can you tell me how you ran it? I ensured, that the test failed with a 
> segfault before continuing with the fix. While I did that I indeed placed the 
> file in the wrong directory, but currently I see no test failures locally. I 
> run:
> 
> ./gradlew  -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:cleanTest 
> :systemTests:test --tests test.com.sun.webkit.LocalStorageAccessTest 
> 
> to only invoke the new test. I'll move the file to the package, but I'd like 
> to understand where I went wrong.

That's how I ran it, too. I did it from a clean repo. This was on Windows, but 
shouldn't matter.

-------------

PR: https://git.openjdk.java.net/jfx/pull/458

Reply via email to