On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph <ajos...@openjdk.org> wrote:
> Issue: Java application (with WebView) will completely freeze after using it
> for a while.
>
> Fix: Use native isMainThread functions instead of JNI call.
The code changes look good. I still need to test it. Speaking of which, I
presume you've tested this on all three platforms?
I left one question inline.
@johanvos, @arapte, or @guruhb can one of you be the second reviewer?
modules/javafx.web/src/main/native/Source/WTF/wtf/java/MainThreadJava.cpp line
45:
> 43: #elif OS(WINDOWS)
> 44: static ThreadIdentifier mainThread { 0 };
> 45: #endif
Both here and below, where the `isMainThread` is defined, assume that `UNIX`
and `WINDOWS` are the only two options. I presume this is a valid assumption?
-------------
PR: https://git.openjdk.java.net/jfx/pull/461
