Good, since these are the sort of behavioral changes we almost always
avoid. That change in the default behavior likely would not have been
approved.
As for the rest, I'll need some time to fully understand the impact of
the proposed behavior for propagating isTextBaseline up the tree, and
how that interacts with prefBaseline. It seem like it might be tricky to
document and for app developers to understand all the ramifications.
A couple questions: First, I presume you are only proposing to propagate
isTextBaseline up the scene graph, meaning that all parents would report
textBaseline == true if that parent is a text baseline node (e.g.,
Labeled, TextFlow) or if any descendant is? Second, given that
isTextBaseline is not immutable, have you considered whether it should
be a read-only property, so an application could listen for changes or
bind to it? There would likely be a performance trade-off in making it a
property.
-- Kevin
On 4/16/2021 8:58 AM, Michael Strauß wrote:
That's true, and it also seems like outside of synthetic tests, the
benefit from this optimization diminishes in larger scene graphs. So I
will revert this change.
Am Fr., 16. Apr. 2021 um 16:28 Uhr schrieb Scott Palmer <swpal...@gmail.com>:
“ I've changed the default alignment for
Label to TOP_LEFT (the default alignment of the base class Labeled is
CENTER_LEFT).”
How can you do that without breaking things? Even though it may be uncommon to
set minHeight or prefHeight, that isn’t the point. It still breaks existing
code.
Scott
