On Mon, 19 Apr 2021 12:51:06 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
> This PR enables ignored unit tests from MenuItemTest and fixes them. > 4 ignored tests are fixed. > 2 ignored tests are removed. > 2 new tests are added. > > **Before fix :** > total tests = 89 > failures = 0 > ignored tests = 6 > > **After fix :** > total tests = 89 > failures = 0 > ignored tests = 0 It looks like you concluded that the implementation is correct, and that the ignored tests were making bad assumptions. Can you add your evaluation to this PR explaining why the tests are incorrect? ------------- PR: https://git.openjdk.java.net/jfx/pull/466
