On Thu, 22 Apr 2021 18:41:43 GMT, Paweł Kruszczyński 
<[email protected]> wrote:

>> `Tooltip` is no longer hiding upon receiving 
>> `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on 
>> overlaying tooltip also kills the tooltip, so the infinite duration tooltip 
>> can be closed.
>
> Paweł Kruszczyński has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8261221: Tooltip bigger than screen size blinks - applying reviewed fixes

I see that the unit tests fails on a couple platforms (although mac failure 
looks like a network problem with the GitHub actions server). Since you are 
several commits out of date, can you merge in the latest changes from upstream 
master into your branch?

And speaking of tests, can you create an automated unit test to verify this fix?

I presume you've tested this with normal sized tooltips. Have you found any 
differences in behavior in those cases with the added event filtering?

I also left one more formatting comment below.

-------------

PR: https://git.openjdk.java.net/jfx/pull/395

Reply via email to