On Thu, 22 Apr 2021 11:58:33 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8264127: >> Fixed another index case based on code review > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java > line 867: > >> 865: @Test >> 866: public void testChangeIndexToEditing3_jdk_8264127() { >> 867: assertChangeIndexToEditing(1, -1); > > hmm .. don't quite understand this: the list's editing state shouldn't be > changed and here it is never editing. What's the intention? I guess it doesn't make sense. Probably missunderstanding somewhere. Should i remove? This would also get rid of the if in the test. ------------- PR: https://git.openjdk.java.net/jfx/pull/441