On Thu, 13 May 2021 21:18:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> On closer inspection, I am reverting my earlier change to `gradlew` (the one > that reverted the setting of `DEFAULT_JVM_OPTS` to a 64Mbyte heap). The > `gradle` launcher in gradle 7.0.1 also sets its `DEFAULT_JVM_OPTS` to a > 64Mbyte heap as you can see in the following, taken from > `gradle-7.0.1/bin/gradle`: > > ``` > # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to > pass JVM options to this script. > DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' > ``` > > So even though I agree that a 64 Mbyte heap is a bit on the small side, it's > more important that running `gradlew` behave the same as installing gradle > and running `$GRADLE_HOME/bin/gradle`. Plus I'd prefer not to maintain local > modifications of this upstream script. I don't think this is a good idea. The only modification of the wrapper scripts would need to be the removal of the heap setting, nothing else. Setting 64MB heap will definitely cause performance issues for JFX builds (because of Garbage collection, not enough memory for caching, ...). + the previous setting was not to restrict the heap in Wrapper scripts. So someone already removed the heap setting as 64MB is the setting back from at least Gradle 4. ------------- PR: https://git.openjdk.java.net/jfx/pull/498
