On Sat, 15 May 2021 12:42:56 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> A test of our CI build with gradle 7.0.1 and JDK 16.0.1 revealed a latent bug > in `build.gradle` in the `fetchExternalTools()` method. It checks the size of > an `ArrayList` in two places, but rather than calling the `size()` method it > omits the `()` which means it is accessing the private `size` field. > > Starting in JDK 16, which has default strong encapsulation, this no longer > works, so we need to fix this before switching. We really should fix it > anyway, since accessing the internal field is both unnecessary and wrong. lgtm, Did not find any other instance where `size` member variable is used. ------------- Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/503