On Mon, 17 May 2021 14:20:33 GMT, Jose Pereda <jper...@openjdk.org> wrote:
> Just added two minor comments. Updated PR according to comments, please have a re-look. > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 456: > >> 454: } >> 455: >> 456: private boolean resetInProgress = false; > > Add a new line? Added a new line. > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 607: > >> 605: // CssStyleHelper.CacheContainer.smapId as key. >> 606: // So, when resetToInitialValues() is in progress: the >> StyleManager.styleMapList gets updated >> 607: // and getStyleMap(node) may return an incorrect >> StyleMap for a given node. > > Probably a better wording could be: > > // When resetToInitialValues() is in progress, the > StyleManager.styleMapList gets updated, therefore > // calls to getStyleMap(node) should be avoided, as it may return an > incorrect StyleMap for a given node. Changed the two lines as suggested. ------------- PR: https://git.openjdk.java.net/jfx/pull/504
