On Wed, 19 May 2021 14:15:00 GMT, Marius Hanl <github.com+66004280+mara...@openjdk.org> wrote:
>> ~~Note: I reported the bug already, waiting for approval. Internal tracking >> id: 9070318. I will update the title as soon as the ticket is created.~~ >> EDIT: Changed the title. :) >> >> This PR is fixing a NP, which is thrown when you press ENTER on an editbale >> table, after it is initially shown. >> >> When pressing ENTER, **TableViewBehaviorBase#activate** is retrieving the >> current focused row (**getFocusedCell()**) and from there the corresponding >> table column. >> This is null, when a table is initially shown. It can also be null, when the >> items from the underlying table are changed (e.g. **setItems()**) or when >> **getFocusModel().focus(row)** is used. >> Therefore, null is a valid value and we should guard against it. > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review comment (changed from NP to NPE) Fix looks good - verified that the new tests fail before and pass after ------------- Marked as reviewed by fastegal (Committer). PR: https://git.openjdk.java.net/jfx/pull/505
