On Fri, 21 May 2021 13:10:50 GMT, Kevin Rushforth <[email protected]> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modify test to avoid online resources
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/ImageStorageTest.java
> line 91:
>
>> 89: @Test
>> 90: public void testLoadAllFramesAnimatedGIF() throws
>> ImageStorageException {
>> 91: String path =
>> "https://upload.wikimedia.org/wikipedia/commons/2/2c/Rotating_earth_%28large%29.gif";;
>
> Except for specific network tests we don't want to load anything from the
> internet during a run. For one thing this will fail behind a firewall
> (without setting a proxy, which we don't want to require). For another, the
> content could change out from under us.
>
> The best solution would be to generate a synthetic image with properties that
> will cause it to fail (we can't use a preexisting image due to copyright
> issues).
Okay, I've replaced the test with an encoded image of a single frame. It fails
with IAOOB without the fix, passes with it.
-------------
PR: https://git.openjdk.java.net/jfx/pull/513
![https://upload.wikimedia.org/wikipedia/commons/2/2c/Rotating_earth_%28large%29.gif"](https://upload.wikimedia.org/wikipedia/commons/2/2c/Rotating_earth_%28large%29.gif"){kind=link}