On Mon, 24 May 2021 11:56:35 GMT, Jose Pereda <[email protected]> wrote:
> ListPropertyBase::bind, SetPropertyBase::bind, MapPropertyBase::bind have a > check on whether a different instance of the observable is the same, and this > PR changes that to check against identity. > > Tests are included. This seems like the right fix to me, but it begs the question of why `.equals()` was used in the first place when these classes were created. It's possible that it was just a mistake. Can you think of any cases where two sets that are not the same object, but are `equals` should be treated as the same for the purpose of checking whether to unbind? I can't, but want to take a closer look. ------------- PR: https://git.openjdk.java.net/jfx/pull/516
