On Thu, 27 May 2021 12:58:26 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ambarish Rapte has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - minor: format correction >> - add test > > modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/StyleManagerTest.java > line 1121: > >> 1119: actualChecksum += Integer.toString((b & 0xff) + 0x100, >> 16).substring(1); >> 1120: } >> 1121: assertEquals(expectedChecksum, actualChecksum); > > It might be clearer to use a `byte` array for the expected checksum and use > `Arrays.equals()` to compare them rather than converting to a `String`. I'm > scratching my head over the formula in the `Integer.toString` call. I have updated the test to use a byte array. Some byte values are greater than 128, those are the negative values. ------------- PR: https://git.openjdk.java.net/jfx/pull/518
