On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This can be fixed with the option `cmd /s`, >> which prevents interpreting quotes on the rest of the command line. The >> result is as if the rest of the command line had been typed verbatim at the >> command prompt. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into fixes/JDK-8267059 > - Use cmd /s option when building on Windows I've tested the `:clean` and `:apps` tasks on Windows, Linux, and macOS: On Windows 10 20H2, `:clean` and `:apps` fail before and succeed after the fix. On macOS 10.15.1, `:clean` and `:apps` succeed before and after the fix. On Ubuntu 20.04, `:clean` succeeds before and after the fix. The `:apps` task fails before and after the fix: [javac] Compiling 143 source files to /home/ubuntu/jfx/apps/samples/3DViewer/build/classes [javac] error: invalid flag: @/home/ubuntu/jfx/build/compile.args [javac] Usage: javac <options> <source files> [javac] use --help for a list of possible options ------------- PR: https://git.openjdk.java.net/jfx/pull/499
