On Fri, 4 Jun 2021 21:56:32 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 15 commits: >> >> - Merge branch 'master' into feature/image-datauri >> >> # Conflicts: >> # >> modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/ImageStorageTest.java >> - Accept regular file paths, change javadoc >> - Merge branch 'openjdk:master' into feature/image-datauri >> - Rename DataURI.isValidURI >> - Reverted a change >> - Allow leading and trailing whitespace in data URI >> - Removed test >> - Changed data URI detection >> - Merge branch 'master' into feature/image-datauri >> - Moved test >> - ... and 5 more: >> https://git.openjdk.java.net/jfx/compare/7b7050c4...315523c5 > > modules/javafx.graphics/src/main/java/com/sun/javafx/iio/ImageStorage.java > line 333: > >> 331: loader = getLoaderBySignature(theStream, listener); >> 332: } >> 333: } catch (Exception e) { > > Is this change needed? If a MIME type other than `image` was specified in the data URL, `IllegalArgumentException` is thrown. If we only catch `IOException` here, the IAE will not be wrapped into a `ImageStorageException`. ------------- PR: https://git.openjdk.java.net/jfx/pull/508
