On Tue, 1 Jun 2021 10:34:34 GMT, Jeanette Winzenburg <[email protected]> wrote:
>> the bug is an incorrect edit location (for tree: treeItem) in edit cancel >> events - expected is the location at the time the cell edit was started, >> actual was the location of at the time the edit was cancelled. See the >> report for details. >> >> Fixed by storing the edit location in startEdit and use that in cancelEdit. >> >> Added tests that failed before and passed after and tests that (accidentally >> :) passed before and still pass after. > > Jeanette Winzenburg has updated the pull request incrementally with one > additional commit since the last revision: > > fixed memory leak introduced in previous version Fix looks good to me. Nicely written tests! Some of them passed without this fix (you have mentioned this in the PR description) - but, good to have them for covering all scenarios. ------------- Marked as reviewed by aghaisas (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/524
