On Tue, 8 Jun 2021 14:47:39 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed doc review comments > > tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java > line 65: > >> 63: LightingTest.light = LIGHT; >> 64: new Thread(() -> Application.launch(TestApp.class, (String[]) >> null)).start(); >> 65: assertTrue("Timeout waiting for FX runtime to start", >> startupLatch.await(5, TimeUnit.SECONDS)); > > We should be using at least a 10 second startup timeout. See > [JDK-8198587](https://bugs.openjdk.java.net/browse/JDK-8198587). I copied this from some other class, so I did a search and found the following tests calling `startupLatch.await` with less than 10 seconds: `HeadlessGeometry1Test` `HeadlessGeometry2Test` `TextNodeTest` ------------- PR: https://git.openjdk.java.net/jfx/pull/334