On Fri, 18 Jun 2021 14:21:16 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> This PR modifies the PasswordField's bullet character used on Android, as 
>> the current unicode code is not supported for most fonts, including Roboto.
>
> modules/javafx.controls/src/android/java/javafx/scene/control/skin/TextFieldSkinAndroid.java
>  line 82:
> 
>> 80:             return String.valueOf(BULLET).repeat(txt.length());
>> 81:         } else {
>> 82:             return txt;
> 
> Should this call `return super.maskText(txt);` in case the implementation of 
> the superclass method ever changes? Either is OK with me.

I think that makes sense, even if it causes a double check of getSkinnable(), 
but that seems negligible. I'll update it

-------------

PR: https://git.openjdk.java.net/jfx/pull/537

Reply via email to