On Fri, 18 Jun 2021 13:23:14 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vsConstants.h line 58: >> >>> 56: float4x3 mBones[MAX_BONES] : register(c35); >>> 57: >>> 58: float4 gReserved240[16] : register(c240); >> >> `gReserved240` is now at the wrong location (it should be 245), so if it >> were ever used it would be a problem. It should be updated to avoid >> confusion at least. > > I think the size should be updated to 11 as well (since we probably don't > want to go past 256). I wonder why we need `gReserved240` and `gSomethingElse` (in the pixel shader) at all. If they are at the end, they don't need to be reserved I think. Also, the vertex shader has `gReserved5[5]` that reserves c5 to c9, but the pixel shader does not have anything on c2 and c3, which are also reserved for something. Another thing I don't understand is why the vertex shader overlaps register definitions for `gAmbinet` and `gAmbinetData[10]`, and `mWorld` and `mBones[MAX_BONES]` (and why 70 of these?). ------------- PR: https://git.openjdk.java.net/jfx/pull/334
