> Issue was that the cancel event carried the listView's editingIndex at the > time of firing the event - that's wrong nearly always (because the list's > editing state/index might have changed between start and cancel, f.i. due to > calling list.edit(someDifferentIndex)). > > Fixed by keeping the index at startEdit and using that in cancelEdit (similar > approach as in TreeCell fix [TreeCell fix > JDK-8265210](https://bugs.openjdk.java.net/browse/JDK-8265210). > > Added tests that are failing (and one that was accidentally passing) before, > all passing after.
Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision: changed scope of field indexAtStartEdit to private ------------- Changes: - all: https://git.openjdk.java.net/jfx/pull/539/files - new: https://git.openjdk.java.net/jfx/pull/539/files/1d08587c..41be1163 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=539&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=539&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/539.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/539/head:pull/539 PR: https://git.openjdk.java.net/jfx/pull/539
