On Fri, 25 Jun 2021 13:08:36 GMT, Michael Strauß <[email protected]> wrote:
>> The documentation for `ObservableListBase.nextRemove` states that a single
>> change always refers to the current state of the list, which likely means
>> that multiple disjoint removed ranges need to be applied in order, otherwise
>> the next change's `getFrom` doesn't refer to the correct index.
>>
>> `SelectedItemsReadOnlyObservableList` doesn't apply removals to
>> `itemsRefList`, which means that subsequent removals will refer to the wrong
>> index when retrieving the removed elements. This PR fixes the calculation of
>> the current index.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> changes per review
modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java
line 109:
> 107:
> 108: @Override public int getRemovedSize() {
> 109: checkState();
Is this needed here? Just wondering because it was not there before.
-------------
PR: https://git.openjdk.java.net/jfx/pull/478
