On Thu, 1 Jul 2021 01:38:14 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
> Not sure why, but our finish() handle was not implemented on OSXPlatform. > This handle should pause media stream when called. Also, seek should restart > playback when we finish playing video. With proposed fix OSXPlatform will > behave same as GSTPlatform. Stop playback when stopTime is reached and resume > playback if seek is performed after EndOfMedia or stopTime is reached. This looks good. I can confirm that this fixes the problem. I did notice one small difference remains between `GSTPlatform` and `OSXPlatform`. With `OSXPlatform`, if I advance the media location slider to be after the stop time, the audio sometimes starts playing again. This doesn't happen with `GSTPlatform`. This seems like a bit of a corner case, though and seems like something that could be handled in a follow-up fix. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/559
