On Thu, 29 Jul 2021 14:11:15 GMT, Jeanette Winzenburg <faste...@openjdk.org> 
wrote:

> The NPE was an indirect effect: 
> 
> - the bug on part of the cell was an incorrect (== missing) edit location in 
> cellEditEvent - that's fixed in this PR
> - a related bug is on part of the implementation of CellEditEvent (assuming 
> that TablePosition != null, 
> [JDK-8269871](https://bugs.openjdk.java.net/browse/JDK-8269871) which is not 
> addressed in this PR
> 
> Fix is to use the cell's state at startEdit for creating the editing 
> location, added tests starting the edit on the cell that failed/passed 
> before/after the fix, also added sanity tests with starting edit on the 
> control that passed before/after.

Marked as reviewed by aghaisas (Reviewer).

The fix looks good to me.

-------------

PR: https://git.openjdk.java.net/jfx/pull/592

Reply via email to