On Thu, 26 Aug 2021 14:09:58 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
> The issue is unguarded access to tablePosition though it might be null (since > [JDK-8120610](https://bugs.openjdk.java.net/browse/JDK-8120610) > > The fix is to check against null in each accessor. Also required to fix the > default onEditCommit handlers in Tree/TableColumn to really cope with null > TablePostion on the event. > > Added tests that failed/pass before/after the fix. > > Note that there was an old test (in Tree/TableColumnTest each), that failed > after the fix because it expected the NPE. Fixed by removing the expected > parameter. Looks good to me. Good to see this fixed, I remember I had some NPEs in the past because of a null table position. 😃 ------------- Marked as reviewed by mhanl (Author). PR: https://git.openjdk.java.net/jfx/pull/611
