On Tue, 7 Sep 2021 14:53:50 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
> this PR fixes the inconsistent event firing pattern in cell's xxEdit methods > (please see the issue for more details): > > - fires event if column != null > - accesses table state if table != null > > The first requires a change in CellEditEvent which now allows null table in > its constructor. > > Added tests that failed/passed before/after the fix (along with some that > also passed before for complete coverage of state permutations). Changed two > old test methods which passed/failed before/after the fix - but did test the > wrong thingy anyway ;) Looks good to me. 👍 ------------- Marked as reviewed by mhanl (Author). PR: https://git.openjdk.java.net/jfx/pull/620
