On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker <[email protected]> wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
modules/javafx.graphics/src/main/java/com/sun/javafx/font/WindowsFontMap.java
line 32:
> 30: class WindowsFontMap {
> 31:
> 32: private static class FamilyDescription {
Isn't that basically a `record` in disguise?
Letting this class be a record would remove a lot of lines, especially down
below.
Also, it would come with the benefit of not having to worry about whether these
values have been changed or not as they would then always be final.
To me at least it does not look as if variables of this class should be mutable
after having been created.
-------------
PR: https://git.openjdk.java.net/jfx/pull/627
