On Fri, 24 Sep 2021 20:31:14 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> John Hendrikx has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > gradle/verification-metadata.xml line 121: > >> 119: <sha256 >> value="569b6977ee4603c965c1c46c3058fa6e969291b0160eb6964dd092cd89eadd94" >> origin="Generated by Gradle"/> >> 120: </artifact> >> 121: </component> > > Why the dependency on junit 4.13.2? The vintage engine pulls this in, so I think we may be forced to upgrade from 4.8.2 JUnit 4 to 4.13.2 JUnit 4 as well, although the current setup seems to work (I remember some Rules being deprecated in later JUnit 4, specifically rules for catching exceptions which could require rewriting those tests to use `assertThrows`). > gradle/verification-metadata.xml line 247: > >> 245: <sha256 >> value="e08028131375b357d1d28734e9a4fb4216da84b240641cb3ef7e7c7d628223fc" >> origin="Generated by Gradle"/> >> 246: </artifact> >> 247: </component> > > Is `apiguardian` actually required in order to support JUnit 5? If not, this > should be reverted. If so, that's another third-party dependency we would > need to get approval for. It's an annotation used within JUnit code, it might be possible to block this one, I will see how to do this in Gradle syntax. This is the whole transitive tree it pulls in:  > gradle/verification-metadata.xml line 273: > >> 271: <component group="org.hamcrest" name="hamcrest-core" >> version="1.3"> >> 272: <artifact name="hamcrest-core-1.3.jar"> >> 273: <sha256 >> value="66fdef91e9739348df7a096aa384a5685f4e875584cce89386a7a47251c4d8e9" >> origin="Generated by Gradle"/> > > Is `hamcrest` actually required in order to support JUnit 5? If not, this > should be reverted. If so, that's another third-party dependency we would > need to get approval for. I will try block this and get back to you. > gradle/verification-metadata.xml line 345: > >> 343: <sha256 >> value="a96e671816c1ff8803bdec74c9241f025bdfb277da5d2b4ee02266405936f994" >> origin="Generated by Gradle"/> >> 344: </artifact> >> 345: </component> > > Is `opentest4j` actually required in order to support JUnit 5? If not, this > should be reverted. If so, that's another third-party dependency we would > need to get approval for. Will try block ------------- PR: https://git.openjdk.java.net/jfx/pull/633
