On Wed, 7 Jul 2021 22:33:07 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> This PR sets an unified logic to every **startEdit()** method of all Cell
> implementations.
> So startEdit() is always doing the same now:
>
> `super.startEdit();`
> `if (!isEditing()) {
> return;
> }`
>
> This will prevent a NPE while also being cleaner (no more double checks)
> The commits are splitted into 4 base commits:
> - First commit changes the startEdit() for TableCell implementations (8 files)
> - Second commit changes the startEdit() for TreeTableCell implementations (7
> files)
> - Third commit changes the startEdit() for ListCell implementations (7 files)
> - Fourth commit changes the startEdit() for TreeCell implementations (7 files)
>
> While writing tests, I found out that the CheckBoxListCell and the
> CheckBoxTreeCell don't disable their CheckBox, which is wrong.
> In CheckBoxTableCell and CheckBoxTreeTableCell the CheckBox is disabled, but
> they don't check their dependencies e.g. TableColumn for null, leading to a
> NPE if not set.
>
> I wrote a follow-up and assigned it to myself:
> https://bugs.openjdk.java.net/browse/JDK-8270042
> The aim of this should be, that all 4 CheckBox...Cells have a proper CheckBox
> disablement while also being nullsafe.
>
> ~Note 1: I removed the tests in TableCellTest added in
> https://github.com/openjdk/jfx/pull/529 in favor of the new parameterized
> TableCellStartEditTest~
> Note 2: This also fixes https://bugs.openjdk.java.net/browse/JDK-8268295
This pull request has now been integrated.
Changeset: 64aa9263
Author: Marius Hanl <mh...@openjdk.org>
Committer: Jeanette Winzenburg <faste...@openjdk.org>
URL:
https://git.openjdk.java.net/jfx/commit/64aa92631fa5aad9293553e8dd174eab647de2f3
Stats: 934 lines in 28 files changed: 625 ins; 257 del; 52 mod
8188026: TextFieldXXCell: NPE on calling startEdit
8268295: Tree- and TableCell sub implementations should respect the row
editability
Reviewed-by: fastegal, aghaisas
-------------
PR: https://git.openjdk.java.net/jfx/pull/569
