On Fri, 2 Apr 2021 10:45:47 GMT, yosbits <github.com+7517141+yos...@openjdk.org> wrote:
>> dannygonzalez has updated the pull request incrementally. > > It seems that performance improvement PR often needs to make up for the lack > of existing unit tests. However, this addition of unit tests should not be > included in the same PR as it needs to be tested to meet the specifications > before and after the change. > > **I think we need a step to fix the lack of unit tests before the performance > improvement patch.** > > And care must be taken not to rely on internal implementations for this unit > test so as not to hinder performance improvement. Some existing unit test > code depends on the internal implementation, so some test changes may be > needed. This change is very near completion. According to @yososs, what remains is to split the work into two separate PRs. The first PR must contain the updated test covering additional cases to ensure backwards compatibility. The second should contain the performance enhancement changes. This will allow the tests to be merged into master first, to ensure the behavior is maintained before and after the performance enhancement. I see that @dannygonzalez has not been able to continue this work. If possible and appropriate, I would like to finish this work. I have already setup a build environment and have verified that the updated tests alone pass when integrated with the master branch and have 100% coverage of the modified class. ------------- PR: https://git.openjdk.java.net/jfx/pull/108
