On Tue, 5 Oct 2021 13:18:07 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
> cell startEdit is supposed to update the editing location on its associated > control - was done in ListCell, not in Tree-/TableCell nor TreeCell. > > Fix was to add control.edit(..). Note that ListCell was also touched to use > the exact same method call pattern as the fixed cell types. > > Added/unignored cell tests that are failing/passing before/after the fix. Looks good, just left one minor comment. :) modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java line 549: > 547: int editingRow = 1; > 548: cell.updateIndex(editingRow); > 549: TablePosition<?,?> editingCell = new TablePosition<>(table, > editingRow, editingColumn); Minor: There is a space missing in `<?,?>` ------------- Marked as reviewed by mhanl (Author). PR: https://git.openjdk.java.net/jfx/pull/638
