On Wed, 27 Oct 2021 09:50:32 GMT, Jeanette Winzenburg <faste...@openjdk.org> 
wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkin.java
>>  line 134:
>> 
>>> 132:                 // that when it changes, we can appropriately add / 
>>> remove cells that may or may not
>>> 133:                 // be required (because we remove all cells that are 
>>> not visible).
>>> 134:                 
>>> registerChangeListener(getVirtualFlow().widthProperty(), e -> 
>>> tableView.requestLayout());
>> 
>> If this listener is removed, then is there a chance of reintroducing 
>> [JDK-8144500](https://bugs.openjdk.java.net/browse/JDK-8144500)?
>> Unfortunately, there is no test added for that bug.. so it is difficult to 
>> catch regression, if any.
>
> hmm .. the listener is not removed, its registration is moved to 
> updateTableViewSkin. There are tests covering that it really is still 
> registered :)
> 
> Forgot to move the old code comment, though. Re-added.

Thanks for the explanation.

-------------

PR: https://git.openjdk.java.net/jfx/pull/632

Reply via email to