On Wed, 27 Oct 2021 08:12:05 GMT, Johan Vos <j...@openjdk.org> wrote:
> This looks like a good solution, and I agree it fixes the issue. I have 2 > minor concerns: > > 1. Are we sure there are no platform-specific restrictions when using a `+` > in a filename? > 2. Testing this is probably difficult. We can only test it if a build is > created (and the versionInfo is set). > > I think the second concern can not be handled by our current test battery, > but we do some smoke tests before releasing the maven repository, which > should be able to detect this. If you are confident about the first concern, > I think we're all good on this. I tested the change by manipulating the folder value in `NativeLibLoader` on multiple jfx versions. That worked well. Today I tested the '+' sign for folders on windows (nfts) and different formatted usb sticks (Tried FAT, FAT32, exFat), linux and mac. They all work. If we want to be really safe we can replace a + by - or something else, but not sure if really needed. I agree it's hard to test. I also thought of writing a test but it's not really possible. The libraries are also loaded different (no cache directory is created). ------------- PR: https://git.openjdk.java.net/jfx/pull/654
