On Tue, 2 Nov 2021 10:15:41 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has the drawback of rerendering, whenever a window is "reshown", but it >> restores sanity about memory behaviour, which should be considered more >> important. > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8269907 > We now require the rendering lock when cleaning up dirty nodes. To do so, > we moved some code required for snapshot into a reusable method. > To solidify my understanding - the "RenderScenegraph" is only allowed to be > changed when the render lock is held. This scene graph is represented by all > these NG classes, correct? Correct. When the renderLock is not held, the renderer thread is free to render it and can be sure it won't change. I'll take a look at the updated fix. ------------- PR: https://git.openjdk.java.net/jfx/pull/584
