On Tue, 28 Sep 2021 21:01:13 GMT, Martin Fox <d...@openjdk.java.net> wrote:
> There was a mismatch between the way `get_glass_key` generated the Java key
> code for a given key press and how `getKeyCodeForChar` determined the key
> code for the matching character. For example, when pressing the plus sign on
> a US keyboard `get_glass_key` correctly generated `KeyCode.EQUALS` but
> `getKeyCodeForChar("+")` generated `KeyCode.PLUS`.
>
> In this PR `getKeyCodeForChar` mirrors the behavior of `get_glass_key`; it
> determines which key the character lies on and generates a key code based on
> the unshifted character on the same key.
>
> I'm working on a more comprehensive test case that allows you to press any
> key on the keyboard and test whether a KeyCharacterCombination for that
> character will succeed or not. I've attached it to this thread. It might be
> worth submitting as a manual test case
> [CharComboTest.txt](https://github.com/openjdk/jfx/files/7247265/CharComboTest.txt)
> .
As you recommended in the description, could you please add the attached test
as part of PR as manual test which fails before the fix and passes with the fix?
-------------
PR: https://git.openjdk.java.net/jfx/pull/635
