On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:

>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests 
>> still work.  Also added a single JUnit 5 tests, and confirmed it works.
>> 
>> I've updated the Eclipse project file for the base module only.
>
> John Hendrikx has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Readd junit declaration in allprojects and set junit version to 4.13.2

These are good points regarding test migration. I withdraw the suggestion of 
test segregation.

I would not want to see a wholesale migration of all tests to JUnit5, but I do 
like the idea of migrating on a test-by-test basis if new tests are being added 
to an existing test class where using JUnit 5 would be a benefit.

-------------

PR: https://git.openjdk.java.net/jfx/pull/633

Reply via email to