On Tue, 23 Nov 2021 11:00:51 GMT, Jose Pereda <jper...@openjdk.org> wrote:

> This PR fixes a memory leak, as a follow-up of 
> [JDK-8241840](https://bugs.openjdk.java.net/browse/JDK-8241840).
> 
> The tests pass on desktop (Linux/macOS/Windows) and there is no regression on 
> Android (see [JDK-8254605](https://bugs.openjdk.java.net/browse/JDK-8254605)).

The fix looks good to me. The newly reenabled test doesn't seem to verify the 
fix, though. It passes both before and after the fix on two different systems 
(possibly because some other recent change has made it insufficient to test for 
the leak).

Do you have a test case that fails without this redo fix and passes with it?

-------------

PR: https://git.openjdk.java.net/jfx/pull/677

Reply via email to