On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda <jper...@openjdk.org> wrote:
> This PR enables intersection observer support for WebKit, and includes a > system test. Looks good. I've tested this on all platforms and confirm that it fixes the issue with no regressions that I can see. I also confirm that the new test catches the problem (fails without and passes with the fix), and that this fixes [JDK-8273558](https://bugs.openjdk.java.net/browse/JDK-8273558), which can be closed as a duplicate. I left one minor formatting comment, but unless there are other changes, it probably isn't worth changing it. tests/system/src/test/resources/test/javafx/scene/web/testIObserver.html line 54: > 52: <div id="output">Intersection ratio: <pre>?</pre></div> > 53: </body> > 54: </html> Minor: missing newline at end of file ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/664
